Add suggestions from Scientific Python (#379)

.github/workflows/examples.yaml

@@ -7,6 +7,7 @@ on:
       - main
       - renovate/**
   pull_request:
+  workflow_dispatch:
 
 concurrency:
   cancel-in-progress: true

pyproject.toml

@@ -110,6 +110,11 @@ paths.source = [
 [tool.mypy]
 disallow_subclassing_any = false
 disallow_untyped_decorators = false
+enable_error_code = [
+    "ignore-without-code",
+    "redundant-expr",
+    "truthy-bool",
+]
 explicit_package_bases = true
 ignore_missing_imports = true
 plugins = [
@@ -118,20 +123,33 @@ plugins = [
 ]
 strict = true
 warn_return_any = false
+warn_unreachable = true
 
 [tool.pytest.ini_options]
-addopts = """
-    --color=yes
-    --import-mode=importlib
-    --verbose
-"""
+addopts = [
+    "--color=yes",
+    "--import-mode=importlib",
+    "--strict-config",
+    "--strict-markers",
+    "--verbose",
+    "-ra",
+]
+filterwarnings = [
+    "error",
+]
+log_cli_level = "INFO"
+minversion = 6
 testpaths = [
     "tests",
 ]
+xfail_strict = true
 
 [tool.ruff]
 fix = true
 force-exclude = true
+src = [
+    "src",
+]
 lint.ignore = [
     "COM812",
     "D105",

src/sleplet/functions/slepian.py

@@ -82,9 +82,6 @@ def _check_rank(
         cls,  # noqa: ANN101
         v: int,
     ) -> int:
-        if not isinstance(v, int):
-            msg = "rank should be an integer"
-            raise TypeError(msg)
         if v < 0:
             msg = "rank cannot be negative"
             raise ValueError(msg)

src/sleplet/functions/spherical_harmonic.py

@@ -55,9 +55,6 @@ def _check_ell(
         v: int,
         info: pydantic.ValidationInfo,
     ) -> int:
-        if not isinstance(v, int):
-            msg = "ell should be an integer"
-            raise TypeError(msg)
         if v < 0:
             msg = "ell should be positive"
             raise ValueError(msg)
@@ -72,9 +69,6 @@ def _check_m(
         v: int,
         info: pydantic.ValidationInfo,
     ) -> int:
-        if not isinstance(v, int):
-            msg = "m should be an integer"
-            raise TypeError(msg)
         if abs(v) > info.data["ell"]:
             msg = "the magnitude of m should be less than ell"
             raise ValueError(msg)

src/sleplet/meshes/_mesh_slepian_decomposition.py

@@ -117,9 +117,6 @@ def _detect_method(self: typing_extensions.Self) -> None:
 
     def _validate_rank(self: typing_extensions.Self, rank: int) -> None:
         """Check the requested rank is valid."""
-        if not isinstance(rank, int):
-            msg = "rank should be an integer"
-            raise TypeError(msg)
         if rank < 0:
             msg = "rank cannot be negative"
             raise ValueError(msg)

src/sleplet/meshes/mesh_basis_functions.py

@@ -69,9 +69,6 @@ def _check_rank(
         cls,  # noqa: ANN101
         v: int,
     ) -> int:
-        if not isinstance(v, int):
-            msg = "rank should be an integer"
-            raise TypeError(msg)
         if v < 0:
             msg = "rank cannot be negative"
             raise ValueError(msg)

src/sleplet/meshes/mesh_slepian_functions.py

@@ -71,9 +71,6 @@ def _check_rank(
         cls,  # noqa: ANN101
         v: int,
     ) -> int:
-        if not isinstance(v, int):
-            msg = "rank should be an integer"
-            raise TypeError(msg)
         if v < 0:
             msg = "rank cannot be negative"
             raise ValueError(msg)

src/sleplet/slepian/_slepian_decomposition.py

@@ -123,9 +123,6 @@ def _detect_method(self: typing_extensions.Self) -> None:
 
     def _validate_rank(self: typing_extensions.Self, rank: int) -> None:
         """Check the requested rank is valid."""
-        if not isinstance(rank, int):
-            msg = "rank should be an integer"
-            raise TypeError(msg)
         if rank < 0:
             msg = "rank cannot be negative"
             raise ValueError(msg)