Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit: setthresholdas constructor param #86

Merged
merged 15 commits into from
Jul 25, 2024
Merged

Audit: setthresholdas constructor param #86

merged 15 commits into from
Jul 25, 2024

Conversation

JordyRo1
Copy link
Contributor

@JordyRo1 JordyRo1 commented Jul 17, 2024 •
edited
Loading

Resolves #87

Breaking changes

  • Remove set_thresholdfrom aggregation and mutlisig contracts
  • Define the threshold in the constructor, with a range validation check

@JordyRo1 JordyRo1 changed the title Audit setting thresholdas constructor param Audit: setting thresholdas constructor param Jul 17, 2024
@JordyRo1 JordyRo1 changed the title Audit: setting thresholdas constructor param Audit: setthresholdas constructor param Jul 18, 2024
@JordyRo1 JordyRo1 merged commit 647fe8b into main Jul 25, 2024
4 checks passed
@JordyRo1 JordyRo1 deleted the Audit-setting-`threshold`as-constructor-param branch July 25, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvolveArt EvolveArt EvolveArt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit: threshold set as constructor
2 participants
@JordyRo1 @EvolveArt