Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pubgrub to get range display changes #444

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Bump pubgrub to get range display changes #444

merged 1 commit into from
Nov 20, 2023

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Nov 17, 2023

@zanieb
Copy link
Member Author

zanieb commented Nov 17, 2023

This should show | in the long version ranges but I guess we don't have any in our test snapshots so there's no diff there.

@zanieb
Copy link
Member Author

zanieb commented Nov 17, 2023

e.g. from #423

... And because dependencies of transformers[tensorboard] at version ==4.34.0 are unavailable and dependencies of transformers[tensorboard] at version ==4.34.1 are unavailable, transformers[tensorboard]<4.35.0 | >4.35.0, <4.35.1 | >4.35.1, <4.35.2 | >4.35.2 is forbidden., ...

@zanieb zanieb requested a review from charliermarsh November 17, 2023 17:15
@charliermarsh
Copy link
Member

Is this an improvement as long as there are still commas between the version pairs?

@zanieb
Copy link
Member Author

zanieb commented Nov 17, 2023

@charliermarsh yes instead of using , everywhere this uses , for and and | for or.

@zanieb zanieb merged commit e9b6fb9 into main Nov 20, 2023
3 checks passed
@zanieb zanieb deleted the zanie/pubrub-5 branch November 20, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants