Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[red-knot] Once again, add more tests asserting that the VendoredFileSystem and the VERSIONS parser work with the vendored typeshed stubs #11987

Merged
merged 3 commits into from
Jun 23, 2024

Conversation

AlexWaygood
Copy link
Member

This reapplies #11970, which was previously reverted in #11975 as the tests failed on Windows. The tests should now pass on Windows thanks to #11982; but if they do fail again, it should be easier to debug them now, thanks to #11983.

…FileSystem and the `VERSIONS` parser work with the vendored typeshed stubs" (#11975)"

This reverts commit 611f4e5.
@AlexWaygood AlexWaygood added the red-knot Multi-file analysis & type inference label Jun 23, 2024
Copy link

codspeed-hq bot commented Jun 23, 2024

CodSpeed Performance Report

Merging #11987 will improve performances by 5.06%

Comparing retry-more-typeshed-tests (e9b377c) with main (92b145e)

Summary

⚡ 1 improvements
✅ 29 untouched benchmarks

Benchmarks breakdown

Benchmark main retry-more-typeshed-tests Change
linter/default-rules[pydantic/types.py] 1.9 ms 1.8 ms +5.06%

@AlexWaygood AlexWaygood merged commit f846fc9 into main Jun 23, 2024
20 checks passed
@AlexWaygood AlexWaygood deleted the retry-more-typeshed-tests branch June 23, 2024 13:57
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant