Copy the Python 3.13t executable to the canonical name instead of renaming #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/copy-rename
branch
from
8130aaa to
d400427
Compare
zanieb
force-pushed
the
zb/copy-rename
branch
from
d400427 to
06e50e8
Compare
This was referenced Dec 6, 2024
|
I'll test this artifact on a Windows machine — previously we did not test a virtual environment. |
|
I downloaded All appears working on Windows 11 FWIW
|
charliermarsh
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the simplest immediate fix for #405
The main downside here is increased artifact size. I think that's okay for now, we can remove the extra binary in the future once we resolve the root cause. It's only 89K.