Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a default compaction policy for journal #37

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

cqs21
Copy link
Contributor

@cqs21 cqs21 commented May 22, 2024

No description provided.

@tatetian
Copy link
Collaborator

@lucassong-mh Could you give the first-round review comments?

core/src/layers/2-edit/journal.rs Outdated Show resolved Hide resolved
core/src/layers/2-edit/journal.rs Outdated Show resolved Hide resolved
core/src/layers/2-edit/journal.rs Outdated Show resolved Hide resolved
core/src/layers/2-edit/journal.rs Outdated Show resolved Hide resolved
core/src/layers/2-edit/journal.rs Outdated Show resolved Hide resolved
core/src/layers/2-edit/journal.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@tatetian tatetian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@tatetian tatetian merged commit 6324394 into asterinas:main Jun 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants