support for HERO8 and MAX

.clang-format

@@ -0,0 +1 @@
+BasedOnStyle: Chromium

.gitignore

@@ -1,3 +1,7 @@
-.**
+.pio/**
+.vscode/**
+.travis.yml
+lib/**
+test/**
+include/**
 platformio.ini
-examples/*/Constants.h

README.md

@@ -1,12 +1,12 @@
 # GoPro Control Arduino
 
-This is a library to interface with GoPro cameras over WiFi, just press a button and control your GoPro action camera using an Arduino!
+This is a library to interface with GoPro cameras over WiFi using Arduino!
 
 ![Alt text](/extras/gopro3_and_nodemcu.jpg?raw=true "GoPro3")
 
 ![Alt text](/extras/gopros_and_esps.jpg?raw=true "GoPro4")
 
-Have you ever thought about the possibility to control your action camera with your Arduino? Well if you are here because you googled that you may be interested in watching this video
+Here there is a short video that shows the potential of the library
 
 [![Alt text](https://img.youtube.com/vi/PuM-ZQ2tMW0/0.jpg)](https://www.youtube.com/watch?v=PuM-ZQ2tMW0)
 
@@ -23,7 +23,7 @@ Have you ever thought about the possibility to control your action camera with y
 - change photo and video resolution
 - turn the localization on/off
 - change the orientation
-- more?
+- more
 
 ## Supported boards:
 
@@ -33,7 +33,7 @@ Have you ever thought about the possibility to control your action camera with y
 - MKR WiFi 1010
 - MKR VIDOR 4000
 - UNO WiFi Rev.2
-- any arduino boards (UNO, nano, 101, etc.) attached to an ESP8266 (ESP01) using AT commands with [this library](https://github.com/bportaluri/WiFiEsp)
+- any other boards (UNO, NANO, bluepill) attached to an ESP01 using AT commands with [this library](https://github.com/bportaluri/WiFiEsp)
 
 ## Supported cameras:
 
@@ -43,6 +43,8 @@ Have you ever thought about the possibility to control your action camera with y
 - HERO6
 - HERO7
 - FUSION
+- HERO8
+- MAX
 
 I made the library with a style which would be quite easy to add other cameras (not only GoPro). I would be very happy to accept pull requests 😃
 
@@ -52,7 +54,7 @@ I made the library with a style which would be quite easy to add other cameras (
 	- Go to Tools > Manage libraries
 	- Search for `GoProControl`
 - PlatformIO:
-	- From command line: run `pio lib install "GoProControl"`
+	- From command line: run `pio lib install "GoProControl"` or use the ID `pio lib install 5599`
 	- Or if you prefer a GUI from [Platformio IDE](https://docs.platformio.org/en/latest/librarymanager/)
 - Manually:
 	- `cd $HOME/Arduino/libraries` ([see Arduino library paths for other operating systems](https://www.arduino.cc/en/hacking/libraries))
@@ -61,11 +63,13 @@ I made the library with a style which would be quite easy to add other cameras (
 
 ## Examples
 
-**Important:** Rename the `Constants.h.example` to `Constants.h` and change the SSID, password and camera model
+Start with the `GoProControl.ino` to get used with the library
+
+**Important:** Before uploading to your board you have to change the SSID, password and camera model from `Secrets.h`
 
 ## Supported Options
 
-| Mode | HERO3 | HERO4,5,6,7 |
+| Mode | HERO3 | HERO4 and beyond |
 | --- | :---: | :---: |
 | VIDEO_MODE | ✔ | ✔ |
 | PHOTO_MODE | ✔ | ✔ |
@@ -85,13 +89,13 @@ I made the library with a style which would be quite easy to add other cameras (
 | MULTISHOT_TIMELAPSE_MODE |  | ✔ |
 | MULTISHOT_NIGHTLAPSE_MODE |  | ✔ |
 
-| Orientation | HERO3 | HERO4,5,6,7 |
+| Orientation | HERO3 | HERO4 and beyond |
 | --- | :---: | :---: |
 | ORIENTATION_UP | ✔ | ✔ |
 | ORIENTATION_DOWN | ✔ | ✔ |
 | ORIENTATION_AUTO |  | ✔ |
 
-| Video Resolution | HERO3 | HERO4,5,6,7 |
+| Video Resolution | HERO3 | HERO4 and beyond |
 | --- | :---: | :---: |
 | VR_4K |  | ✔ |
 | VR_2K |  | ✔ |
@@ -104,14 +108,14 @@ I made the library with a style which would be quite easy to add other cameras (
 | VR_720p | ✔ | ✔ |
 | VR_WVGA | ✔ | ✔ |
 
-| Field Of View | HERO3 | HERO4,5,6,7 |
+| Field Of View | HERO3 | HERO4 and beyond |
 | --- | :---: | :---: |
 | WIDE_FOV | ✔ | ✔ |
 | MEDIUM_FOV | ✔ | ✔ |
 | NARROW_FOV | ✔ | ✔ |
 | LINEAR_FOV |  | ✔ |
 
-| Frame Rate | HERO3 | HERO4,5,6,7 |
+| Frame Rate | HERO3 | HERO4 and beyond |
 | --- | :---: | :---: |
 | FR_240 | ✔ | ✔ |
 | FR_120 | ✔ | ✔ |
@@ -128,12 +132,12 @@ I made the library with a style which would be quite easy to add other cameras (
 | FR_12p5 | ✔ |  |
 | FR_12 | ✔ |  |
 
-| Video Encoding | HERO3 | HERO4,5,6,7 |
+| Video Encoding | HERO3 | HERO4 and beyond |
 | --- | :---: | :---: |
 | NTSC | ✔ | ✔ |
 | PAL | ✔ | ✔ |
 
-| Photo Resolution | HERO3 | HERO4,5,6,7 |
+| Photo Resolution | HERO3 | HERO4 and beyond |
 | --- | :---: | :---: |
 | PR_12MP_WIDE |  | ✔ |
 | PR_12MP_MEDIUM |  | ✔ |
@@ -147,7 +151,7 @@ I made the library with a style which would be quite easy to add other cameras (
 | PR_5MP_WIDE | ✔ | ✔ |
 | PR_5MP_MEDIUM |  | ✔ |
 
-| Time Lapse | HERO3 | HERO4,5,6,7 |
+| Time Lapse | HERO3 | HERO4 and beyond |
 | --- | :---: | :---: |
 | 60 | ✔ | ✔ |
 | 30 | ✔ | ✔ |
@@ -156,26 +160,27 @@ I made the library with a style which would be quite easy to add other cameras (
 | 1 | ✔ | ✔ |
 | 0.5 | ✔ | ✔ |
 
-| Continuous Shot | HERO3 | HERO4,5,6,7 |
+| Continuous Shot | HERO3 | HERO4 and beyond |
 | --- | :---: | :---: |
 | 10 | ✔ |  |
 | 5 | ✔ |  |
 | 3 | ✔ |  |
 | 0 | ✔ |  |
 
-**NOTE:** Not all the options are available for all the cameras (for example on a HERO3 you can't set 1080p at 240 frame per second 😲). You can see the possibilities on the manual of your camera of here for [HERO3](https://github.com/KonradIT/goprowifihack/blob/master/HERO3/Framerates-Resolutions.md) and here for [HERO4 and newer](https://github.com/KonradIT/goprowifihack/blob/master/HERO4/Framerates-Resolutions.md)
+**NOTE:** Not all the options are available for all the cameras (for example on a HERO3 you can't set 1080p at 240 frame per second 😲). You can see the possibilities on the manual of your camera or here for [HERO3](https://github.com/KonradIT/goprowifihack/blob/master/HERO3/Framerates-Resolutions.md) and here for [HERO4 and newer](https://github.com/KonradIT/goprowifihack/blob/master/HERO4/Framerates-Resolutions.md)
 
 ## To Do list and known issues
 
 - ESP8266 can't get the BSSID of the camera. So if you want to turn it on you need to manually pass it to the constructor, [see the docs](https://arduino-esp8266.readthedocs.io/en/latest/esp8266wifi/station-class.html#bssid)
 - There is no way to know if an HERO3 camera is on or off so the function `isOn()` will always return `true` on this camera
-- It is possible to get a lot of info (mode, fow, battery) from HERO4 and newer camera but this is not implemented, [see here](https://github.com/KonradIT/goprowifihack/blob/master/HERO5/HERO5-Commands.md#gopro-hero5-commands-status-and-notes) - PR are welcome
+- It is possible to get a lot of info (mode, fow, battery) from HERO4 and newer camera but this is not implemented [see here](https://github.com/KonradIT/goprowifihack/blob/master/HERO5/HERO5-Commands.md#gopro-hero5-commands-status-and-notes), a Json parser should be used, like [ArduinoJson](https://arduinojson.org/) - PR are welcome
 - BLE not implemented: the ESP32 core is not enough stable, especially, if used together with wifi: [see here](https://github.com/espressif/arduino-esp32/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+ble)
 - No confirm pairing for HERO4: [see here](https://github.com/KonradIT/goprowifihack/blob/master/HERO4/WifiCommands.md#code-pairing) - PR are welcome
 - The arduino class `String()` is known to cause memory leaks but in hours and hours of use of this library I never had a single problem
+- on STM32 there is a known bug with [WiFiEsp](https://github.com/bportaluri/WiFiEsp/pull/179)
 
 ## Reference
 
-All the commands came from [here](https://github.com/KonradIT/goprowifihack)
+All the commands came from the great work of [KonradIT](https://github.com/KonradIT/goprowifihack)
 
-The idea of making a GoPro library for arduino comes from another [library](https://github.com/agdl/GoPRO) which works only on arduino WiFi boards and only with GoPro HERO3
+The idea of making a GoPro library for arduino comes from another [library](https://github.com/agdl/GoPRO) which works only on arduino WiFi boards and only with GoPro HERO3