Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds pay as bid option to the complex clearing #520

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

nick-harder
Copy link
Member

@nick-harder nick-harder commented Dec 10, 2024

Pull Request

Related Issue

Closes #[issue number] (if applicable)

Description

Right now the compex clearing supports only pay as clear and with the nodal clearing removed we no longer have an option for zonal clearings with pay as bid option. This PR addresses this issue by including this functionality to the complex clearing

Changes Proposed

-add pricing mechanism as param_dict argument
-move log_flows also to the param_dict
-update the docstrings for better explanation
-rename the market clearing to complex clearing
-rename it in config files and add param_dict for demonstration

  • run pre-commit (apparently this was not done before the release)

Testing

[Describe the testing you've done, including any specific test cases or scenarios]

Checklist

Please check all applicable items:

  • Code changes are sufficiently documented (docstrings, inline comments, doc folder updates)
  • New unit tests added for new features or bug fixes
  • Existing tests pass with the changes
  • Reinforcement learning examples are operational (for DRL-related changes)
  • Code tested with both local and Docker databases
  • Code follows project style guidelines and best practices
  • Changes are backwards compatible, or deprecation notices added
  • New dependencies added to pyproject.toml
  • A note for the release notes doc/release_notes.rst of the upcoming release is included
  • Consent to release this PR's code under the GNU Affero General Public License v3.0

Additional Notes (if applicable)

[Any additional information, concerns, or areas you want reviewers to focus on]

Screenshots (if applicable)

[Add screenshots to demonstrate visual changes]

-add pricing mechanism as param_dict argument
-move log_flows also to the param_dict
-update the docstrings for better explanation
-rename the market clearing to complex clearing
-rename it in config files and add param_dict for demonstration
-run pre-commit
@nick-harder nick-harder requested a review from maurerle December 10, 2024 11:44
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.50%. Comparing base (e4b492f) to head (472f147).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...me/markets/clearing_algorithms/complex_clearing.py 58.33% 5 Missing ⚠️
assume/markets/clearing_algorithms/redispatch.py 0.00% 2 Missing ⚠️
assume/common/grid_utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
- Coverage   77.59%   77.50%   -0.09%     
==========================================
  Files          50       50              
  Lines        6784     6793       +9     
==========================================
+ Hits         5264     5265       +1     
- Misses       1520     1528       +8     
Flag Coverage Δ
pytest 77.50% <46.66%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

assume/markets/clearing_algorithms/complex_clearing.py Outdated Show resolved Hide resolved
@nick-harder nick-harder merged commit ac41e2c into main Dec 11, 2024
6 of 7 checks passed
@nick-harder nick-harder deleted the add-pay-as-bid-to-comlex-clearing branch December 11, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants