Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a default message handler #511

Closed
wants to merge 3 commits into from
Closed

Conversation

maurerle
Copy link
Member

@maurerle maurerle commented Dec 5, 2024

alternative to OFFIS-DAI/mango#144

This logs exceptions in scheduled tasks correctly.
Related to #510

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.51%. Comparing base (5aa8a5c) to head (72bcf67).

Files with missing lines Patch % Lines
assume/world.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
- Coverage   76.53%   76.51%   -0.02%     
==========================================
  Files          51       51              
  Lines        6874     6878       +4     
==========================================
+ Hits         5261     5263       +2     
- Misses       1613     1615       +2     
Flag Coverage Δ
pytest 76.51% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maurerle
Copy link
Member Author

maurerle commented Dec 9, 2024

I would like to leave this open for now.

@nick-harder nick-harder marked this pull request as draft December 9, 2024 14:25
@maurerle
Copy link
Member Author

maurerle commented Dec 9, 2024

will be closed as this is fixed in mango which was released today https://github.com/OFFIS-DAI/mango/releases/tag/v2.1.3

@maurerle maurerle closed this Dec 9, 2024
@maurerle maurerle deleted the improve_error_handling branch December 9, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants