-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
<!-- SPDX-FileCopyrightText: ASSUME Developers SPDX-License-Identifier: AGPL-3.0-or-later --> # Pull Request ## Related Issue Closes #321 ## Description As suggested by @maurerle this improves performance of all simulations by a factor of 2 up to 4, by replacing pandas actions with numpy where possible. For this, we are using a wrapper object FastIndex and FastSeries which wraps a numpy array so that we can access it using typical datetime accessors. The speed up for small simulations is 2x and for large simulations 3x. ## Changes Proposed - Shift to using special classes of FastIndex and FastSeries - Adjust the rest of the code to make use of this new class ## Testing Most of the tests pass and simulations work, but a more extensive testing is required to test full functionality. ## Checklist Please check all applicable items: - [x] Code changes are sufficiently documented (docstrings, inline comments, `doc` folder updates) - [x] New unit tests added for new features or bug fixes - [x] Existing tests pass with the changes - [x] Reinforcement learning examples are operational (for DRL-related changes) - [x] Code tested with both local and Docker databases - [x] Code follows project style guidelines and best practices - [ ] Changes are backwards compatible, or deprecation notices added - [ ] New dependencies added to `pyproject.toml` - [x] A note for the release notes `doc/release_notes.rst` of the upcoming release is included - [x] Consent to release this PR's code under the GNU Affero General Public License v3.0 ## Additional Notes (if applicable) [Any additional information, concerns, or areas you want reviewers to focus on] ## Screenshots (if applicable) [Add screenshots to demonstrate visual changes] --------- Co-authored-by: Florian Maurer <[email protected]>
- Loading branch information
1 parent
7d5465b
commit b9cf60e
Showing
60 changed files
with
2,843 additions
and
1,288 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.