Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation based on Jelle's feedback #22

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Improve documentation based on Jelle's feedback #22

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38c0817
Improve documentation based on Jelle's feedback
abelsiqueira Aug 17, 2023
72eb35e
Update 40-kubernetes.md
abelsiqueira Aug 17, 2023
ae03dc5
Update 40-kubernetes.md
abelsiqueira Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions 40-kubernetes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ echo -n 'WHATEVER' | base64

Copy that value and paste in the appropriate field of the file.

Finally, run the secret:
Finally, apply the secret configuration:

```bash
kubectl apply -f s3-secret.yml
Expand All @@ -133,7 +133,7 @@ To change that, edit [tasker.sh](code/tasker.sh).

The [tasker.sh](code/tasker.sh) defines everything that will be executed by the tasker, and indirectly by the workers.
The [tasker.Dockerfile](code/tasker.Dockerfile) will create the image that will be executed in the tasker pod.
You can modify these as you see fit.
You can modify these files as you see fit.

The default commands used inside the tasker script and Dockerfile assume that you are:

Expand Down Expand Up @@ -223,7 +223,7 @@ Change the `image` to reflect the path to the image that you pushed.

> **Warning**
>
> Did you change the image?
> Don't forget to change the image in the worker.yml file.
abelsiqueira marked this conversation as resolved.
Show resolved Hide resolved

You can select the number of `replicas` to change the number of workers.
Pay attention to the resource limits, and change as you see fit.
Expand Down Expand Up @@ -261,7 +261,7 @@ Change the `image`, and optionally add a `ttlSecondsAfterFinished` to auto delet

> **Warning**
>
> Did you change the image?
> Don't forget to change the image in the tasker.yml file.
abelsiqueira marked this conversation as resolved.
Show resolved Hide resolved

Run

Expand Down
2 changes: 1 addition & 1 deletion 42-kubernetes-cloud-provider.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ nfs-service ClusterIP NFS_SERVICE_IP <none> 2049/TCP,20048/TCP,1
```

Copy the `NFS_SERVICE_IP`.
Then, uncomment the [worker.yml](k8-config/worker.yml) and [tasker.yml](k8-config/tasker.yml) relevant part at the `volumes` section in the end.
Then, uncomment the first 3 lines of the `volumes` sections of files [worker.yml](k8-config/worker.yml) and [tasker.yml](k8-config/tasker.yml) (end of the file).
For this case, it should look like

```yml
Expand Down