Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix README #29

Merged
merged 1 commit into from
Jun 18, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 1 addition & 78 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PoBFrontend
===========

A cross-platform [Path of Building](https://github.com/Openarl/PathOfBuilding) driver.
A cross-platform [Path of Building](https://github.com/PathOfBuildingCommunity/PathOfBuilding.git) driver.

Building
--------
Expand All @@ -20,80 +20,3 @@ Building
- meson
- pkg-config
- ninja (optional, can tell meson to generate makefiles if you prefer)

### Build Lua-Curl:

You need to build [Lua-Curl](https://github.com/Lua-cURL/Lua-cURLv3) for luajit.

Edit the Lua-Curl Makefile:

```diff
@@ -7,7 +7,7 @@ DESTDIR ?= /
PKG_CONFIG ?= pkg-config
INSTALL ?= install
RM ?= rm
-LUA_IMPL ?= lua
+LUA_IMPL ?= luajit
CC ?= $(MAC_ENV) gcc

LUA_VERSION = $(shell $(PKG_CONFIG) --print-provides --silence-errors $(LUA_IMPL))
```

Run make. You should get `lcurl.so`.

### Get the PoBFrontend sources:

`git clone https://github.com/philroberts/pobfrontend.git`

### Build:

```bash
meson -Dbuildtype=release pobfrontend build
cd build
ninja
```

Run the thing:

```bash
cd /path/to/PathOfBuilding # <- a pathofbuilding git clone
for f in tree*.zip; do unzip $f;done # <- use the provided tree data because reasons
unzip runtime-win32.zip lua/xml.lua lua/base64.lua lua/sha1.lua
mv lua/*.lua .
rmdir lua
cp /path/to/lcurl.so . # our lcurl.so from earlier
/path/to/build/pobfrontend
```

You can adjust the font size up or down with a command line argument:

```bash
pobfrontend -2
```

### Notes:

I have the following edit in my PathOfBuilding clone, stops it from saving builds even when I tell it not to:

```diff
--- a/Modules/Build.lua
+++ b/Modules/Build.lua
@@ -599,7 +599,7 @@ function buildMode:CanExit(mode)
end

function buildMode:Shutdown()
- if launch.devMode and self.targetVersion and not self.abortSave then
+ if false then --launch.devMode and self.targetVersion and not self.abortSave then
if self.dbFileName then
self:SaveDBFile()
elseif self.unsaved then
```

###### OS X

On mac you need to invoke meson with some extra flags, per the luajit documentation:

```bash
LDFLAGS="-pagezero_size 10000 -image_base 100000000" meson pobfrontend build
```

Loading