fix: Use js_binary in macro in external repository #1342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Test plan
In vgijssel/setup#601 I tried using
js_binary
from within a macro calledrelease_manager
which was located in the rules_release workspace. The rules_release macro was called from the main workspace which resulted in the following error:After asking in the Bazel community https://bazelbuild.slack.com/archives/C014RARENH0/p1698918118051159
@fmeum
found the issue: the js_binary is a macro which uses labels which are not wrapped in theLabel
class, causing them to be scoped to the main repository. Wrapping these labels with Label class fixes the issue.