Skip to content

Commit

Permalink
Fix rules to work with --incompatible_auto_exec_groups
Browse files Browse the repository at this point in the history
  • Loading branch information
dzbarsky committed Dec 13, 2024
1 parent cd48714 commit 691e468
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .github/workflows/bazel7.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ common --noexperimental_check_external_repository_files
# but got [email protected] in the resolved dependency graph.
common --check_direct_dependencies=off

# Make sure we don't regress this.
common --incompatible_auto_exec_groups

# Directories used by sandboxed non-worker execution may be reused to avoid unnecessary setup costs.
# Save time on Sandbox creation and deletion when many of the same kind of action run during the
# build.
Expand Down
2 changes: 1 addition & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module(

# Lower-bounds (minimum) versions for direct runtime dependencies.
# Do not bump these unless rules_js requires a newer version to function.
bazel_dep(name = "aspect_bazel_lib", version = "2.8.1")
bazel_dep(name = "aspect_bazel_lib", version = "2.9.2")
bazel_dep(name = "bazel_features", version = "1.9.0")
bazel_dep(name = "bazel_skylib", version = "1.5.0")
bazel_dep(name = "platforms", version = "0.0.5")
Expand Down
1 change: 1 addition & 0 deletions e2e/bzlmod/other_module/MODULE.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
module(name = "other_module")

bazel_dep(name = "aspect_bazel_lib", version = "2.9.2")
bazel_dep(name = "aspect_rules_js", version = "0.0.0")

npm = use_extension("@aspect_rules_js//npm:extensions.bzl", "npm")
Expand Down
1 change: 1 addition & 0 deletions npm/private/npm_package_store.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,7 @@ def _npm_package_store_impl(ctx):
"--directory",
package_store_directory.path,
],
toolchain = "@aspect_bazel_lib//lib:tar_toolchain_type",
mnemonic = "NpmPackageExtract",
progress_message = "Extracting npm package {}@{}".format(package, version),
)
Expand Down

0 comments on commit 691e468

Please sign in to comment.