-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some features #58
base: master
Are you sure you want to change the base?
Conversation
Fix misspelled variable Co-authored-by: Daniël Klabbers <[email protected]>
Co-authored-by: Alexander Skvortsov <[email protected]>
Co-authored-by: Alexander Skvortsov <[email protected]>
@askvortsov1 How do you think of these features or have any other features are valuable to add? |
First stage: Added network and install alerts, badge and instant sw update support. |
Planned changes sound good! Offline cache might be cool, but I also worry that this could be a deep dark rabbit hole. One thing that people have reported that might be useful is better pusher / websockets refresh functionality with PWAs; iirc, on Discuss some people have complained that discussions don't automatically refresh / that there might not be a good mechanism for manually refreshing |
I know, so they can only use 3rd-party pusher / websockets for now.
Rest assured. For now I am planning to cache only |
One solution is using 3rd-party php extention, I found swoole and workerman. |
Hey @DellZHackintosh! Should I review the current state of this PR? |
Hello @askvortsov1, thank you for your interest in the current state of this PR. |
No rush at all, thanks again for your contributions, and good luck with your exams! |
Second Stage: Kill switch, install alert, files cache and custom offline |
Third stage. |
How things work now
Features that cannot be completed for the time being
Looking forward to implementing more. |
Ok I realized that the "not configured" alert has the same bug on my side too, so it's may not my fault......Well, ship it now. |
This pull aims to add a set of new features to improve the users experience. The following features are currently planned to be added to this pull:
Every time a new notification comes, display a badge on the App icon.
Tell users something important is happening.
Currently with no offline app experience, only cache files.
If admin disable this extension, it'll leave a sw. Open the kill switch to unregister the sw.
size: any
).Related Needs