Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix on logging #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Maggi-Andrea
Copy link

@Maggi-Andrea Maggi-Andrea commented Jan 22, 2020

Description

The redirect_stdouts contextmanager need to save the previous stdout and stderr before redirecting to be able to restore the situation as it has found before.

@codecov-io
Copy link

codecov-io commented Jan 22, 2020

Codecov Report

Merging #57 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   96.99%   96.99%   +<.01%     
==========================================
  Files          27       27              
  Lines        3824     3826       +2     
  Branches      417      417              
==========================================
+ Hits         3709     3711       +2     
  Misses        102      102              
  Partials       13       13
Impacted Files Coverage Δ
mode/utils/logging.py 91.7% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9725a34...33df4b3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants