Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate system-building from the transport layer #12

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Separate system-building from the transport layer #12

wants to merge 8 commits into from

Conversation

SamuelSarle
Copy link
Contributor

No description provided.

@SamuelSarle SamuelSarle marked this pull request as draft November 18, 2024 21:15
artob
artob requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@artob artob left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagged several issues to address in the next draft:

  • I doubt we can get away with the connect signature change
  • Also, the validate method consumes its argument unnecessarily

lib/protoflow-core/src/system.rs Outdated Show resolved Hide resolved
lib/protoflow-blocks/src/system.rs Outdated Show resolved Hide resolved
lib/protoflow-core/src/system.rs Outdated Show resolved Hide resolved
lib/protoflow-core/src/system.rs Outdated Show resolved Hide resolved
@artob artob added the enhancement New feature or request label Nov 19, 2024
@artob artob changed the title Move transport layer creating connections from SystemBuilding to SystemExecution Separate system-building from the transport layer Nov 19, 2024
@SamuelSarle SamuelSarle marked this pull request as ready for review November 22, 2024 11:37
@SamuelSarle SamuelSarle assigned artob and unassigned SamuelSarle Nov 22, 2024
@SamuelSarle
Copy link
Contributor Author

I left out the DefinedSystem, PreparedSystem, etc. separation from this PR as I think this is large enough on it's own, and those changes are somewhat orthogonal even if the topic is similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artob artob Awaiting requested review from artob artob is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@artob artob

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamuelSarle @artob