Add delete method to Object class #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What comes back from the API when you call delete? |
|
When I log out the response, it looks like an associative array with one key and an empty value.
produces
|
|
Ah looks like it returns nothing. Returning true in your case make sense, I'll do the merge. Thanks! |
|
Hi there, @ashwinks. Is there anything else I can do here to help out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wrapper has almost everything that I need except this part: being able to delete a card via the API. I've added a delete() in the Object class right below the get() method and it works like a charm.
My question is- what should be returned once the card is deleted? I've currently got it returning true and it seems to work, but I'm not sure if that's the best thing to use in this situation.