Update onboarding.css - Use CSS variables #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See Issue: #9 - Added :root to hold CSS variables - Replaced hard coded values with CSS variables
ashlyn
requested changes
Sep 29, 2021
There was a problem hiding this comment.
Hi @calvinmorett, sorry for the delayed response; I've taken a bit of a break from this small personal project. Would you mind merging all of these change sets into a single PR? That would help me manage the Google Chrome Web Store submission process with a single block of changes. Also, I'd prefer the names of these color variables to be simplified a bit, something similar to the guidelines proposed in this article.
If you're no longer interested in contributing, let me know and I'll take over development on these PRs. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue: #9