Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSS variables rather than copying colors, spacing, etc. throughout. #9

Open
ashlyn opened this issue Jul 21, 2021 · 1 comment
Open
Labels
foundational Technical work only, not adding/changing user-facing features good first issue Good for newcomers

Comments

@ashlyn
Copy link
Owner

ashlyn commented Jul 21, 2021

No description provided.

@ashlyn ashlyn added foundational Technical work only, not adding/changing user-facing features good first issue Good for newcomers labels Jul 21, 2021
@calvinmorett
Copy link

calvinmorett commented Jul 27, 2021

Hey there Ash, I saw your good first issue and wanted to contribute! 🧇


image

  • Updated onboarding.css, radio.css, toggle.css, and site.css to all use the same CSS variables: for Colors.
  • Sorry for so many PRs!
:root{
    /* ### Theme Colors ### */
    /* Note: #14919b ! since this is used frequently, you could call this a theme color var */
    --theme_ashblu: #14919b; /* used in var --rad_label_i-chk */
    /* Note: #E5E5E5 ! is used frequently too */ 
    --theme_ashmercury: #E5E5E5; /* used in --feature_border */
    --theme_ashash: #333333;
    --theme_ashblu_darker: #0e7c86; /* DARKER THEME COLOR */
    --theme_ashblu_dark: #30919c; /* DARKER THAN THEME COLOR, LIGHTER THAN DARKER THEME COLOR */

    /* ### SRC/ONBOARDING ### */
    /* onboarding.css */
    --body_bg: #FAFAFA;
    --feature_bg: #FFF; /* can be used for rad label span / --rad_label_span */
    --feature_border: var(--theme_ashmercury); /* can be used for rad label input disabled / --rad_label_i-dis */

    /* ### SRC/OPTIONS ### */
    /* radio.css */
    --rad_label_i-chk: var(--theme_ashblu); /* can be used for rad label span box shadow / --rad_label_span_bs */
    --rad_label_i-dis: var(--feature_border);
    --rad_label_span: var(--feature_bg);
    --rad_label_span_bs: var(--rad_label_i-chk);

    /* toggle.css */
    /* Created Theme Variables */
    /* theme: _ashblue / _ashmercury */
    
    /* ### SRC/SHARED ### */
    /* site.css */
    /* Created Theme Variables */
    /* theme: _ashash / _ashblu_darker / _ashblu_dark */
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
foundational Technical work only, not adding/changing user-facing features good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants