sorting: its not working lol #45

ashlsun · 2024-07-11T04:16:25Z

the placement of the sorting select input is just temporary - could imagine this just being moved into a settings box or be something like cickable table headings on a grid layout, like spotify

anyway i was just trying to see if i could get it to work but . i don't think i fully understand svelte reactivity cause i initially just tried to mutate list and changed it to this when it wasn't visibly updating anything. it still doesn't visibly update 😞
this is the error i got
after switching to "a to z"

i wonder what a proxy array / object is & why its not just a regular list?
im also finding it interesting that this null error comes after sorting and assigning. is it happening somewhere in the components?

Rettend · 2024-07-11T23:26:03Z

i did a major refactor and changed some behaviors a little:

adding an already existing item now increments the quantity
this also fixes adding random items when they are full
when selecting items with the up/down arrows, it now jumps between storages upon reaching the edge

ideas for further improvs:

add a small delay when pressing down the up/down arrow keys, it currently navigates so fast you can't see it
use numbers and maybe ctrl to quickly navigate between storages. like ctrl + 1 to select the first item of the first storage, ctrl + 2 to select the second storage's first item (oh ctrl + a number already jumps between tabs in the browser so we would need different shortcuts or maybe override the broswer's?)
fix sorting aaaaaa

ashlsun · 2024-07-12T04:16:23Z

noticing:

if a user is visiting for the first time (if nothing is in the db) there are no storage places on the screen. i think it would be nice to display an empty fridge and empty freezer
item count doesn't update
sorting is sorta working?? just sorts according to the previously chosen sortBy
previously, deleting the last item in a storage place set the new last item as the selected, which i think would be nice to keep!
previously, entering a new item will unselect any selected item in the storage place, now it stays selected

hmm and i am having trouble reproducing this, but there was a moment upon first loading when pressing enter would not add an item (the input text would disappear but the item would not be created)! i'll keep my eyes peeled if it happens again

ashlsun · 2024-07-12T04:23:42Z

i love the wrapping to the next storage when reaching the edge tho 🤩

ashlsun · 2024-07-12T05:08:51Z

i thought it might make more sense to just have the parsing happen in StoragePlace instead of the store, which avoids the add/import naming confusion

ashlsun · 2024-07-12T13:41:24Z

wondering why sorting is non responsive and then works after a little bit for me
https://github.com/user-attachments/assets/b23cc3da-2189-455d-96a3-0d60623b4c73

nvm!! might have been the item.name as id

ashlsun · 2024-07-12T13:45:59Z

ok so i added an apple just now, and then i updated its dateAdded to be 14d ago. when sorting by newest it should be the middle item, but it seems like it still treats it as the newest
https://github.com/user-attachments/assets/d8159a9c-933d-42fd-91e5-f0c01a235295

might also make sense to start with sort by: none at first, and then if a sort by option is selected, any changes to any of the items in the relevant attributes might cause them to be resorted

Rettend · 2024-07-12T16:07:47Z

ok so i added an apple just now, and then i updated its dateAdded to be 14d ago. when sorting by newest it should be the middle item, but it seems like it still treats it as the newest https://github.com/user-attachments/assets/d8159a9c-933d-42fd-91e5-f0c01a235295

might also make sense to start with sort by: none at first, and then if a sort by option is selected, any changes to any of the items in the relevant attributes might cause them to be resorted

i could not reproduce that bug you had, but added the 'none' sort option. when adding a new item it switches to none, but this does not work when adding random items (debug feature anyway)

Rettend · 2024-07-12T17:03:25Z

how about this?

a text x wouldn't be bad either but cant really increase the font size, or the gap between them grows too:

* item count was not reactive, can't make $derived value with parameter so a record of itemCounts was created * fixed: tests that used text="delete" broke after swapping it to an icon

Rettend · 2024-07-12T21:27:28Z

use flexbox on storages, row wrap for desktop. col for mobile

Rettend · 2024-07-13T08:00:25Z

tailwind.config.js

@@ -23,7 +23,10 @@ export default {
      customise: (content, name, prefix) => {
        switch (prefix) {
          case 'tabler':
-            return content.replaceAll('stroke-width="2"', 'stroke-width="3"')
+            if (name === 'x')


…rage

ashlsun · 2024-07-17T04:41:50Z

src/lib/stores/item.svelte.ts

+      if (!storages.includes(storage)) {
+        storages.push(storage)
+        items[storage] = []
+        await db.foodItems.where('storage').equals(storage).toArray()


is the result of this supposed to be stored anywhere?

hm no that can be removed it seems, no need to query there. i'm still not 100% sure how dexie works

* should work on mobile too

* should not scroll when an item is selected

ashlsun · 2024-07-18T02:45:43Z

huh! pulled the latest updates and encountered this bug where clicking on an item in the 1st storage place ended up selecting an item in 2nd one. after that error, clicking anything else stops working 😮

Screen.Recording.2024-07-17.at.10.30.20.PM.mov

i tried going back one commit at a time, and it seems like the bug doesnt happen until after c02e645, refactor: change sort dropdown handling for tests? checking out 8e6ac1b and running the app, clicking on items seems to work as expected

its the removal of untrack, isnt it?

Rettend · 2024-07-18T08:38:24Z

huh! pulled the latest updates and encountered this bug where clicking on an item in the 1st storage place ended up selecting an item in 2nd one. after that error, clicking anything else stops working 😮

Screen.Recording.2024-07-17.at.10.30.20.PM.mov
i tried going back one commit at a time, and it seems like the bug doesnt happen until after c02e645, refactor: change sort dropdown handling for tests? checking out 8e6ac1b and running the app, clicking on items seems to work as expected

its the removal of untrack, isnt it?

ah sryyyy, it was untrack.

ashlsun and others added 5 commits July 11, 2024 00:15

its not working lol

b380cf3

refactor: sort type string to string literal

565ea01

refactor!: global item store

0fce6dd

refactor: group storage related ops

c5726d8

chore: cleanup

fec5b35

move parsing logic to handler in component, remove importItem

72dead3

Rettend added 3 commits July 12, 2024 14:39

deps: bump svelte and fix sorting bruhhhh

15aff94

chore: resolve conflicts

a3b8350

fix: messed up format in tips

415a86e

Rettend marked this pull request as draft July 12, 2024 13:19

revert: key with id

c0f6ba3

feat: add none sort, remove hardcodes

1ce18b6

Rettend added 2 commits July 12, 2024 18:47

feat: store sorts in localstorage

c5632db

style: change delete text to x icon

8c42358

Rettend added 3 commits July 12, 2024 19:34

fix: item count, tests broken by delete icon

5622ad0

* item count was not reactive, can't make $derived value with parameter so a record of itemCounts was created * fixed: tests that used text="delete" broke after swapping it to an icon

fix: preserve selected item when sorting

e43ed5f

feat: add and rename storages

e109cbd

make x icon a thinner stroke

9ca5c04

Rettend reviewed Jul 13, 2024

View reviewed changes

use option/alt + number to select the first item of corresponding sto…

006edcd

…rage

ashlsun commented Jul 17, 2024

View reviewed changes

ashlsun and others added 6 commits July 17, 2024 00:56

don't select when storage is an empty list

df110db

fix: remove random idb query

b53c7cb

feat: add flex wrapping to storages

133a0f8

* should work on mobile too

fix: prevent scrolling with arrows

8e6ac1b

* should not scroll when an item is selected

refactor: change sort dropdown handling for tests

c02e645

test: add basic tests for storageplace

07b8d8e

fix: ♾️ recursion

f5d663b

ashlsun added 5 commits July 20, 2024 23:34

fix ai workflow

059d52d

clear selection after input

539923d

fix: select previous item if deleting last item

42cc922

handle keyboard navigation at page level instead of item level

9d6c392

fix tests & remove obsolete ones

a1db555

ashlsun marked this pull request as ready for review October 17, 2024 21:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sorting: its not working lol #45

sorting: its not working lol #45

ashlsun commented Jul 11, 2024 •

edited

Loading

Rettend commented Jul 11, 2024 •

edited by ashlsun

Loading

ashlsun commented Jul 12, 2024 •

edited

Loading

ashlsun commented Jul 12, 2024

ashlsun commented Jul 12, 2024

ashlsun commented Jul 12, 2024 •

edited

Loading

ashlsun commented Jul 12, 2024 •

edited

Loading

Rettend commented Jul 12, 2024

Rettend commented Jul 12, 2024 •

edited

Loading

Rettend commented Jul 12, 2024 •

edited

Loading

Rettend Jul 13, 2024

ashlsun Jul 17, 2024

Rettend Jul 17, 2024 •

edited

Loading

ashlsun commented Jul 18, 2024 •

edited

Loading

Rettend commented Jul 18, 2024

sorting: its not working lol #45

Are you sure you want to change the base?

sorting: its not working lol #45

Conversation

ashlsun commented Jul 11, 2024 • edited Loading

Rettend commented Jul 11, 2024 • edited by ashlsun Loading

ashlsun commented Jul 12, 2024 • edited Loading

ashlsun commented Jul 12, 2024

ashlsun commented Jul 12, 2024

ashlsun commented Jul 12, 2024 • edited Loading

ashlsun commented Jul 12, 2024 • edited Loading

Rettend commented Jul 12, 2024

Rettend commented Jul 12, 2024 • edited Loading

Rettend commented Jul 12, 2024 • edited Loading

Rettend Jul 13, 2024

Choose a reason for hiding this comment

ashlsun Jul 17, 2024

Choose a reason for hiding this comment

Rettend Jul 17, 2024 • edited Loading

Choose a reason for hiding this comment

ashlsun commented Jul 18, 2024 • edited Loading

Rettend commented Jul 18, 2024

ashlsun commented Jul 11, 2024 •

edited

Loading

Rettend commented Jul 11, 2024 •

edited by ashlsun

Loading

ashlsun commented Jul 12, 2024 •

edited

Loading

ashlsun commented Jul 12, 2024 •

edited

Loading

ashlsun commented Jul 12, 2024 •

edited

Loading

Rettend commented Jul 12, 2024 •

edited

Loading

Rettend commented Jul 12, 2024 •

edited

Loading

Rettend Jul 17, 2024 •

edited

Loading

ashlsun commented Jul 18, 2024 •

edited

Loading