Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ann capability endpoint to predict scoring #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tee-Hui
Copy link

@Tee-Hui Tee-Hui commented Dec 28, 2020

Created endpoint for score prediction with keras model saved in h5 format.

Copy link
Owner

@ashishawasthi ashishawasthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • requirements.txt should have keras as a dependency
  • PredictionError text should be designed for API client

Copy link
Owner

@ashishawasthi ashishawasthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think PredictionError should be:
Unknown model_lib {self.model_lib}
as the caller of API may not have access to the code.

Name of second model should be iris_ann_v1 to follow the naming convention of first one.

@ashishawasthi
Copy link
Owner

there should be test cases added to test_app.py for ANN, the way test cases are covering the sklearn model

Repository owner deleted a comment from jidalii Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants