Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update window-icons/window-icons.patch #49

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

laur89
Copy link

@laur89 laur89 commented Aug 2, 2019

  • note currenlty only works nicely when title_align=left (default);
    could be modified to support centered- and right alignment, but not
    going to for the sake of keeping the patch as simple as possible.

@ashinkarov
Copy link
Owner

Thanks for the contribution, a few minor notes though:

  1. Could you add a bit of an explanation to your label swapping patch? I can't see why such a patch would be useful, but maybe a small doc would help. Either in the patch itself or in the README.md.
  2. For both patches, can you add a note on the i3 version that these patches were successfully applied to. For example, the window patch doesn't apply to 4.17.1.

@laur89
Copy link
Author

laur89 commented Oct 24, 2019

Will do later when I have more time.

I can't see why such a patch would be useful, but maybe a small doc would help

{v,h}split seem to have different definitions.
I'm used to the one vim (any many other programs) use, where vertically-split entity means the splitting line itself is vertical; having to deal with both ways doesn't play nice with my thinking.

Laur Aliste and others added 8 commits January 29, 2021 03:31
- note currenlty only works nicely when title_align=left (default);
  could be modified to support centered- and right alignment, but not
  going to for the sake of keeping the patch as simple as possible.
- this merely swaps the vsplit & hsplit displayed labels (V & H);
- breaking changes from i3/i3#3759
Laur Aliste and others added 2 commits January 29, 2021 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants