Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of test failure output; occurs 1/10 times or so #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ashander
Copy link
Owner

@ashander ashander commented Jan 26, 2017

@petrelharp two things:

  1. I added a quick commit updating the version of msprime that your latest changes depend on to current master 2150a014094f026e9e19c01809d2df67b3e57190 See git submodule for details
  2. assuming that's the right version, should tests always pass? I get occasional failures. See the file in this PR

@petrelharp
Copy link
Collaborator

Oh, that's great. I was encountering such errors in the much larger sims produced by simupop and was despairing ever finding what the problem was in such large ARGs. I suspect the error is in msprime, but we'll see. I'll debug; but if you need this short-term you can fall back to earlier versions.

@petrelharp
Copy link
Collaborator

Oh, right. The problem is that msprime determines the number of samples automatically as the smallest-numbered internal node. I was not ensuring that this was the case.

This will change soon in msprime, so I am hacking something in.

@petrelharp
Copy link
Collaborator

I fixed that; there remain some issues at least with .simplify():
see https://github.com/jeromekelleher/msprime/pull/131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants