Skip to content
This repository has been archived by the owner on Sep 8, 2020. It is now read-only.

Amount parse enhancement #45

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

beroso
Copy link

@beroso beroso commented Jan 24, 2018

Fix #19

Fix a bug when trying to parse some Santander Bank ofx file
@beroso beroso changed the title Strip whitespaces before preg cheks Amount parse enhancement Jan 24, 2018
@beroso
Copy link
Author

beroso commented Jan 24, 2018

Travis CI build is failing because of this check:

'100' => ['100', 1.0], // @todo this is weird behaviour, should not really expect this

Could you check if it is suitable?

@asgrim
Copy link
Owner

asgrim commented Jan 24, 2018

At the moment, can't merge this as it would be a BC break (hence why that test case exists). Yes, it's stupid behaviour but some may rely on it, unfortunately so I can't change until next major release. Otherwise, will review this in time, but as it's a BC break don't hold your breath ;)

@asgrim asgrim self-assigned this Jan 24, 2018
@asgrim asgrim added the enhancement This adds new functionality or improves existing functionality. label Jan 24, 2018
@asgrim asgrim added this to the 2.0.0 milestone Jan 24, 2018
@beroso
Copy link
Author

beroso commented Jan 24, 2018

Understood.
What are your plans to the next release? I will be glad to help

@asgrim
Copy link
Owner

asgrim commented Jan 29, 2018

Currently, to find time to refactor for better quality, more tests, fix the stupid things that don't make sense and make a minimum PHP 7.1 or 7.2 probably 👍

@asgrim asgrim added the BC break Changes in this PR/issue would result in a BC break label Oct 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
BC break Changes in this PR/issue would result in a BC break enhancement This adds new functionality or improves existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants