This repository has been archived by the owner on Sep 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 103
Amount parse enhancement #45
Open
beroso
wants to merge
7
commits into
asgrim:master
Choose a base branch
from
beroso:fix-parse-amount
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug when trying to parse some Santander Bank ofx file
Travis CI build is failing because of this check:
Could you check if it is suitable? |
At the moment, can't merge this as it would be a BC break (hence why that test case exists). Yes, it's stupid behaviour but some may rely on it, unfortunately so I can't change until next major release. Otherwise, will review this in time, but as it's a BC break don't hold your breath ;) |
asgrim
added
the
enhancement
This adds new functionality or improves existing functionality.
label
Jan 24, 2018
Understood. |
Currently, to find time to refactor for better quality, more tests, fix the stupid things that don't make sense and make a minimum PHP 7.1 or 7.2 probably 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
BC break
Changes in this PR/issue would result in a BC break
enhancement
This adds new functionality or improves existing functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19