Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for pre-existing internet connection #491

Merged
merged 3 commits into from
Aug 19, 2020
Merged

Added check for pre-existing internet connection #491

merged 3 commits into from
Aug 19, 2020

Conversation

adamsclafani
Copy link
Contributor

@adamsclafani adamsclafani commented Aug 12, 2020

IIAB users could have connected their machine with internet from another source (i.e. cellphone tethering, or even an actual wifi connection). A simple internet check was added in order to leverage this existing connection.

See #453

Copy link
Member

@c-w c-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor nitpicks and then this is ready to be merged.

opwen_email_client/webapp/tasks.py Outdated Show resolved Hide resolved
opwen_email_client/webapp/tasks.py Outdated Show resolved Hide resolved
opwen_email_client/util/network.py Outdated Show resolved Hide resolved
@c-w c-w merged commit 06960ae into master Aug 19, 2020
@c-w c-w deleted the internet branch August 19, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants