Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ASCIIMathTeXImg.js UMD compatible and export as NodeJS package #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

meghprkh
Copy link

@meghprkh meghprkh commented Nov 26, 2020

This would allow us to publish and import it as a webpack/nodejs package.

This makes sure anyone using the scripts can continue doing so in the same way.

Note that I am using ASCIIMathTexImg.js here since it converts it to Latex, as anyone using it via webpack/nodejs would likely be using/can easily use Katex/MathJax for rendering latex to HTML or MathML

The UMD export pattern does look a bit ugly to directly add to the source code but is the easiest way forward without adding a build system and refactoring the code.

Note: the noMathRender variable wasn't being used, so I removed it.

@meghprkh
Copy link
Author

meghprkh commented Dec 5, 2020

Hi, did you get a chance to look at this :)

I would like to publish a remarkjs package for the same and if this is merged, it can depend on your package instead of depending on my fork :)

Also cc-ing @adius / @ad-si since he owns the npm package asciimath according to #7 . This does something like #51 but without duplicating code and keeping everything working as it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant