Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #44 - Add default stylesheet to dist and update to 1.5.0 #46

Merged
merged 1 commit into from
Aug 12, 2014

Conversation

anthonny
Copy link
Member

No description provided.

anthonny added a commit that referenced this pull request Aug 12, 2014
Resolve #44 - Add default stylesheet to dist
@anthonny anthonny merged commit 67c5766 into asciidoctor:master Aug 12, 2014
@mojavelinux
Copy link
Member

As a first step, I think it makes sense to distribute the default Asciidoctor stylesheet in this repository since it goes hand-in-hand with Asciidoctor.js. Could you rename it to asciidoctor.css to be consistent with the file name that Asciidoctor writes?

I'd also like to explore making a Bower repo for Asciidoctor Stylesheet Factory, which people can use to get all the other themes. Would you be willing to help setup that repository to distribute the theme files?

Btw, you might want to update commit message to mention that you are also upgrading to 1.5.0.

@anthonny
Copy link
Member Author

Sorry i merged too too fast

@anthonny anthonny changed the title Resolve #44 - Add default stylesheet to dist Resolve #44 - Add default stylesheet to dist and update to 1.5.0 Aug 12, 2014
@anthonny
Copy link
Member Author

Of course i can help on Asciidoctor Stylesheet Factory, with pleasure 👍

@mojavelinux
Copy link
Member

Most excellent!

Btw, we'll get to play with some new tools here because we need...for our sanity...some visual QA for the stylesheets. I had to do so much manual testing.

@anthonny
Copy link
Member Author

@mojavelinux
Copy link
Member

I created a very rough list while we were prepping the release, but it needs a lot more work to be anywhere near a complete list.

https://github.com/asciidoctor/asciidoctor/wiki/Release-Checklist#stylesheet-qa

We're mostly looking at A/B testing here...so we'd need to establish a baseline, then we can get a report whether the change broke anything unexpected. I'm thinking CasperJS is the solution here (see http://casperjs.org/)

Let's convert this into an issue in that repo so we can discuss there.

@mojavelinux
Copy link
Member

Perfect! I'll copy this information into that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants