Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Js Port #83
base: main
Are you sure you want to change the base?
Js Port #83
Changes from 25 commits
8b172ec
16e971c
0a34799
f304423
8a32a2e
50318b4
e07b20a
739381b
b792377
720063a
81e07c7
87e794e
6e99f2a
227a0fd
b0d0e7b
cba9e46
06128bc
1ac728f
9d23ffe
83f42bb
b201866
0f47302
b8ed5ea
b1ea41d
6f6422b
0564033
6b8c909
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mogztter I needed to add this, so it works regardless of the structure. I'm sure this can be written in ruby, but I'm not quite sure how. I tried a few things like
styleFilePath == File.expand_path(styleFilePath, __FILE__)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What
File.expand_path(styleFilePath, __FILE__)
gives you? Maybe__FILE__
is not correctly implemented in Opal... 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be a bug in opal. I tried following code snippet:
With ruby
__FILE__
just gives the file name andexpand_path
the full absolute path.Wit opal (our version & newest) you get the same behaviour for
__FILE__
, butexpand_path
just gives./vendor/styles
.So it seems
expand_path
or__FILE__
is not correctly implemented.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to use File.absolute_path. File.expand_path has some magic behavior that isn't needed here.