objc: prevent defmacro! from mutating its argument

asarhaddon · Aug 27, 2024 · 3b69e86 · 3b69e86
1 parent 57ea2de
commit 3b69e86
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/impls/objc/step8_macros.m b/impls/objc/step8_macros.m
@@ -104,7 +104,7 @@ BOOL starts_with(NSObject *ast, NSString *sym) {
     } else if ([(NSString *)a0 isEqualTo:@"quasiquote"]) {
         ast = quasiquote(alst[1]); // TCO
     } else if ([a0sym isEqualTo:@"defmacro!"]) {
-        MalFunc * f = (MalFunc *)EVAL(alst[2], env);
+        MalFunc * f = [(MalFunc *)EVAL(alst[2], env) copy];
         f.isMacro = true;
         return [env set:alst[1] val:f];
     } else if ([a0sym isEqualTo:@"do"]) {

diff --git a/impls/objc/step9_try.m b/impls/objc/step9_try.m
@@ -104,7 +104,7 @@ BOOL starts_with(NSObject *ast, NSString *sym) {
     } else if ([(NSString *)a0 isEqualTo:@"quasiquote"]) {
         ast = quasiquote(alst[1]); // TCO
     } else if ([a0sym isEqualTo:@"defmacro!"]) {
-        MalFunc * f = (MalFunc *)EVAL(alst[2], env);
+        MalFunc * f = [(MalFunc *)EVAL(alst[2], env) copy];
         f.isMacro = true;
         return [env set:alst[1] val:f];
     } else if ([a0sym isEqualTo:@"try*"]) {

diff --git a/impls/objc/stepA_mal.m b/impls/objc/stepA_mal.m
@@ -104,7 +104,7 @@ BOOL starts_with(NSObject *ast, NSString *sym) {
     } else if ([(NSString *)a0 isEqualTo:@"quasiquote"]) {
         ast = quasiquote(alst[1]); // TCO
     } else if ([a0sym isEqualTo:@"defmacro!"]) {
-        MalFunc * f = (MalFunc *)EVAL(alst[2], env);
+        MalFunc * f = [(MalFunc *)EVAL(alst[2], env) copy];
         f.isMacro = true;
         return [env set:alst[1] val:f];
     } else if ([a0sym isEqualTo:@"try*"]) {