-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for new geocoordinates when marker is dragged #4
base: master
Are you sure you want to change the base?
Conversation
Totally forgot to also add in the |
@jsblair9 Nice one, thanks! I'll try and have a look at the changes this week and give it a little test run. |
@aryehraber thanks! Again I'll reiterate that it's a quick and dirty addition to get the functionality working. Don't think the approach is quite right, especially if any other events were to be added in. But hey, it works for what it does! Thanks for taking a look! |
Hey @jsblair9, sorry about the delay on this one... I finally had a chance to try out the changes but the map doesn't seem to render in the CP. I can see the new |
hmmm... I thought I had addressed that with 4eebf66 but maybe I missed something. I'll double check |
@aryehraber figured it out... forgot to set |
Btw, since you mentioned this was just a "quick and dirty addition", I don't want you to spend too much time on it. I like the idea of having a map render to more accurately pinpoint a location (since I've noticed some addresses being slightly off too), but I rarely use this addon anyway so no worries either way. |
It does seem to work for me without any issue, and no extra settings on the Google places API. really happy to help so no worries at all |
Ok cool, I'll take another stab at it later this week and see if I can figure out why I'm getting the above error. |
It updates the defaults
markerOptions.draggable: true
and then adds a secondbind()
on thegeocode:dragged
trigger event.Just makes it a little easier to pin point an exact location when the address is a little off from the Google Places api.