Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thinning #18

Merged
merged 5 commits into from
Aug 10, 2024
Merged

Add thinning #18

merged 5 commits into from
Aug 10, 2024

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Jul 31, 2024

Adds thinning based on ESS as discussed Säilynoja 2022 and this vignette https://mc-stan.org/posterior/reference/thin_draws.html

I tried with a couple of examples and it works, but not sure I am adding all that is needed. Or if everything is in the right place


📚 Documentation preview 📚: https://arviz-stats--18.org.readthedocs.build/en/18/

src/arviz_stats/base/dataarray.py Show resolved Hide resolved
src/arviz_stats/base/dataarray.py Outdated Show resolved Hide resolved
src/arviz_stats/base/dataarray.py Outdated Show resolved Hide resolved
@OriolAbril
Copy link
Member

This is a very nice feature!

@aloctavodia aloctavodia requested a review from OriolAbril August 8, 2024 20:17
Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two small comments, should be ready to merge after that

src/arviz_stats/base/dataarray.py Outdated Show resolved Hide resolved
src/arviz_stats/base/dataarray.py Show resolved Hide resolved
@aloctavodia aloctavodia merged commit 1fb6c7d into main Aug 10, 2024
4 checks passed
@aloctavodia aloctavodia deleted the thinning branch August 10, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants