Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reloading scripts into redis on "NOSCRIPT" errors. #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

suprememoocow
Copy link

This PR deals with functionality to support Redis Sentinel, but the functionality may be useful in certain circumstances even in non-Redis-Sentinel configurations.

We're currently in the process of migrating to Redis Sentinel. We've selected Node Redis Sentinel Client as our sentinel client.

Unfortunately we're experiencing NOSCRIPT errors with Redis Scripto when switching Redis server instances.

This PR modifieds Scripto so to attempt to re-evaluate a script (once) on a NOSCRIPT error. This is useful for sentinel configurations, but also potentially for situations in which a SCRIPT FLUSH has occurred on a single Redis instance (although this is probably a rare situation).

@CodeAnimal
Copy link

Any chance of pulling this PR?

@tlhunter
Copy link
Contributor

tlhunter commented Dec 5, 2014

nudge nudge

@suprememoocow
Copy link
Author

Hey @tlhunter, @CodeAnimal just to let you know, until this change is accepted into the main repo, I've published a forked npm module here:

npm install gitter-redis-scripto

We've been running it in production since May without problems...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants