Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove from state and do null parent_uid check #46

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

1riatsila1
Copy link
Contributor

Description

  • remove resource from state when not found
  • check for null parent uids

Related Issue(s)

@1riatsila1 1riatsila1 changed the title fix: remove from state and null check fix: remove from state and do null parent_uid check Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@f0c6769). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage        ?   37.58%           
=======================================
  Files           ?       58           
  Lines           ?     8448           
  Branches        ?        0           
=======================================
  Hits            ?     3175           
  Misses          ?     4983           
  Partials        ?      290           
Files with missing lines Coverage Δ
...kg/config-api-provider/provider/resources/group.go 82.50% <100.00%> (ø)
...der/provider/resources/network_group_assignment.go 77.37% <100.00%> (ø)
...g/config-api-provider/provider/resources/sensor.go 86.23% <100.00%> (ø)
...g-api-provider/provider/resources/wired_network.go 85.39% <100.00%> (ø)
...pi-provider/provider/resources/wireless_network.go 85.39% <100.00%> (ø)

@1riatsila1 1riatsila1 merged commit 9acc55a into main Oct 24, 2024
4 checks passed
@1riatsila1 1riatsila1 deleted the ay/fix/state-removal-and-null-check branch October 24, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants