Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete group and sensors get integration #45

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

1riatsila1
Copy link
Contributor

Description

Make use of the delete group and sensors get methods

Related Issue(s)

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 89.18919% with 20 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@617b14e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...onfig-api-provider/provider/data-sources/sensor.go 88.28% 10 Missing and 3 partials ⚠️
...g/config-api-provider/provider/resources/sensor.go 80.55% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage        ?   39.35%           
=======================================
  Files           ?       56           
  Lines           ?     7956           
  Branches        ?        0           
=======================================
  Hits            ?     3131           
  Misses          ?     4542           
  Partials        ?      283           
Files with missing lines Coverage Δ
...kg/config-api-provider/provider/resources/group.go 82.38% <100.00%> (ø)
pkg/config-api-provider/test/util/utils.go 100.00% <100.00%> (ø)
...g/config-api-provider/provider/resources/sensor.go 86.23% <80.55%> (ø)
...onfig-api-provider/provider/data-sources/sensor.go 88.28% <88.28%> (ø)

@1riatsila1 1riatsila1 merged commit 77cf417 into main Oct 22, 2024
4 checks passed
@1riatsila1 1riatsila1 deleted the ay/feat/delete-group-and-sensors-get branch October 22, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants