Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename alias and title to name #42

Merged
merged 9 commits into from
Oct 21, 2024
Merged

Conversation

1riatsila1
Copy link
Contributor

Description

Do some naming alignment

Related Issue(s)

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@f84536b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../config-api-provider/provider/resources/service.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage        ?   38.52%           
=======================================
  Files           ?       53           
  Lines           ?     7235           
  Branches        ?        0           
=======================================
  Hits            ?     2787           
  Misses          ?     4192           
  Partials        ?      256           
Files with missing lines Coverage Δ
...pi-provider/provider/data-sources/wired_network.go 87.25% <100.00%> (ø)
...provider/provider/data-sources/wireless_network.go 88.18% <100.00%> (ø)
...g-api-provider/provider/resources/wired_network.go 85.39% <100.00%> (ø)
...pi-provider/provider/resources/wireless_network.go 85.39% <100.00%> (ø)
pkg/config-api-provider/test/util/utils.go 100.00% <100.00%> (ø)
.../config-api-provider/provider/resources/service.go 75.36% <66.66%> (ø)

opcloete
opcloete previously approved these changes Oct 11, 2024
Base automatically changed from ay/feat/error-handling to main October 21, 2024 09:42
@1riatsila1 1riatsila1 dismissed opcloete’s stale review October 21, 2024 09:42

The base branch was changed.

@1riatsila1 1riatsila1 merged commit 3a09fb1 into main Oct 21, 2024
4 checks passed
@1riatsila1 1riatsila1 deleted the ay/fix/alias-title-name branch October 21, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants