Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: neatening up error handling #41

Merged
merged 7 commits into from
Oct 21, 2024
Merged

Conversation

1riatsila1
Copy link
Contributor

@1riatsila1 1riatsila1 commented Oct 10, 2024

Description

Make a generic error handler for errors that come from the client.
Also dropping some unused mock structs (now that we are using the actual models)

And adding a heap of test cases for errors

Related Issue(s)

https://jira.arubanetworks.com/browse/UXI-8969

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 89.15663% with 18 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@84b984c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...onfig-api-provider/provider/util/error_handling.go 45.45% 16 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage        ?   38.52%           
=======================================
  Files           ?       53           
  Lines           ?     7235           
  Branches        ?        0           
=======================================
  Hits            ?     2787           
  Misses          ?     4192           
  Partials        ?      256           
Files with missing lines Coverage Δ
...config-api-provider/provider/data-sources/group.go 85.05% <100.00%> (ø)
.../provider/data-sources/network_group_assignment.go 82.43% <100.00%> (ø)
...r/provider/data-sources/sensor_group_assignment.go 83.33% <100.00%> (ø)
...pi-provider/provider/data-sources/wired_network.go 87.25% <100.00%> (ø)
...provider/provider/data-sources/wireless_network.go 88.18% <100.00%> (ø)
...kg/config-api-provider/provider/resources/group.go 81.20% <100.00%> (ø)
...der/provider/resources/network_group_assignment.go 77.37% <100.00%> (ø)
...ider/provider/resources/sensor_group_assignment.go 76.69% <100.00%> (ø)
...der/provider/resources/service_group_assignment.go 66.94% <100.00%> (ø)
...g-api-provider/provider/resources/wired_network.go 85.39% <100.00%> (ø)
... and 2 more

@1riatsila1 1riatsila1 merged commit f84536b into main Oct 21, 2024
4 checks passed
@1riatsila1 1riatsila1 deleted the ay/feat/error-handling branch October 21, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants