Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: client | network group assignment alignment and test #37

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

1riatsila1
Copy link
Contributor

Description

Data source for network group assignments
Use get network group assignments method in resources

Related Issue(s)

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 72.00000% with 28 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@9f47971). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../provider/data-sources/network_group_assignment.go 73.33% 12 Missing and 4 partials ⚠️
...der/provider/resources/network_group_assignment.go 47.82% 10 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage        ?   36.13%           
=======================================
  Files           ?       46           
  Lines           ?     4812           
  Branches        ?        0           
=======================================
  Hits            ?     1739           
  Misses          ?     2859           
  Partials        ?      214           
Files with missing lines Coverage Δ
pkg/config-api-provider/test/util/utils.go 100.00% <100.00%> (ø)
...der/provider/resources/network_group_assignment.go 64.94% <47.82%> (ø)
.../provider/data-sources/network_group_assignment.go 73.33% <73.33%> (ø)

@1riatsila1 1riatsila1 merged commit d7f9e76 into main Oct 3, 2024
4 checks passed
@1riatsila1 1riatsila1 deleted the ay/feat/network-group-assignment-use-method branch October 3, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants