Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make use of post sensor group assignment #34

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

1riatsila1
Copy link
Contributor

Description

Integrate Post Sensor Group assignment method

Related Issue(s)

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@ec90dc8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ider/provider/resources/sensor_group_assignment.go 50.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage        ?   34.38%           
=======================================
  Files           ?       44           
  Lines           ?     4644           
  Branches        ?        0           
=======================================
  Hits            ?     1597           
  Misses          ?     2853           
  Partials        ?      194           
Files with missing lines Coverage Δ
pkg/config-api-provider/test/util/utils.go 100.00% <100.00%> (ø)
...ider/provider/resources/sensor_group_assignment.go 60.78% <50.00%> (ø)

Base automatically changed from ay/feat/new-client-methods-1 to main October 2, 2024 08:32
@1riatsila1 1riatsila1 merged commit 7f8f396 into main Oct 2, 2024
4 checks passed
@1riatsila1 1riatsila1 deleted the ay/feat/post-sensor-group-assignment branch October 2, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants