Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disallow root group imports #33

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Conversation

1riatsila1
Copy link
Contributor

Description

No more root groups and data sources

Related Issue(s)

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@268a42b). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage        ?   34.26%           
=======================================
  Files           ?       44           
  Lines           ?     4626           
  Branches        ?        0           
=======================================
  Hits            ?     1585           
  Misses          ?     2848           
  Partials        ?      193           
Files with missing lines Coverage Δ
...config-api-provider/provider/data-sources/group.go 76.11% <100.00%> (ø)
...kg/config-api-provider/provider/resources/group.go 55.35% <100.00%> (ø)
pkg/config-api-provider/provider/util/group.go 100.00% <100.00%> (ø)

Base automatically changed from ay/feat/new-client-methods-1 to main October 2, 2024 08:32
@1riatsila1 1riatsila1 merged commit ec90dc8 into main Oct 2, 2024
4 checks passed
@1riatsila1 1riatsila1 deleted the ay/feat/disallow-root-group branch October 2, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants