Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bring in wired and wireless get endpoints #24

Merged
merged 8 commits into from
Sep 12, 2024

Conversation

1riatsila1
Copy link
Contributor

@1riatsila1 1riatsila1 commented Sep 11, 2024

Description

Bring in Wired and Wireless client methods (and also Groups fix)

Related Issue(s)

https://jira.arubanetworks.com/browse/UXI-8069

@1riatsila1 1riatsila1 changed the title feat: bring in wired and wireless get and post endpoints feat: bring in wired and wireless get endpoints Sep 11, 2024
@1riatsila1 1riatsila1 marked this pull request as ready for review September 11, 2024 15:21
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 15.81798% with 777 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@bb499b2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../config-api-client/model_wireless_networks_item.go 10.43% 203 Missing and 3 partials ⚠️
pkg/config-api-client/model_wired_networks_item.go 10.89% 177 Missing and 3 partials ⚠️
...api-client/model_network_group_assignments_item.go 0.00% 90 Missing ⚠️
...client/model_network_group_assignments_response.go 0.00% 76 Missing ⚠️
pkg/config-api-client/api_configuration.go 51.49% 62 Missing and 3 partials ⚠️
...config-api-client/model_wired_networks_response.go 17.10% 60 Missing and 3 partials ⚠️
...fig-api-client/model_wireless_networks_response.go 17.10% 60 Missing and 3 partials ⚠️
...-api-client/model_sensor_group_assignments_item.go 14.81% 23 Missing ⚠️
pkg/config-api-client/model_groups_get_item.go 0.00% 6 Missing ⚠️
...-client/model_sensor_group_assignments_response.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage        ?   33.81%           
=======================================
  Files           ?       33           
  Lines           ?     3705           
  Branches        ?        0           
=======================================
  Hits            ?     1253           
  Misses          ?     2294           
  Partials        ?      158           
Files with missing lines Coverage Δ
pkg/config-api-client/client.go 22.41% <ø> (ø)
pkg/config-api-client/configuration.go 44.70% <ø> (ø)
pkg/config-api-client/model_error_detail.go 0.00% <ø> (ø)
pkg/config-api-client/model_error_response.go 0.00% <ø> (ø)
pkg/config-api-client/model_groups_get_response.go 17.10% <ø> (ø)
pkg/config-api-client/model_groups_post_request.go 17.10% <ø> (ø)
...kg/config-api-client/model_groups_post_response.go 14.42% <ø> (ø)
pkg/config-api-client/model_pagination_details.go 13.55% <ø> (ø)
pkg/config-api-client/response.go 0.00% <ø> (ø)
pkg/config-api-client/utils.go 6.28% <ø> (ø)
... and 11 more

Copy link
Contributor

@SiasMey SiasMey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@1riatsila1 1riatsila1 merged commit c41adba into main Sep 12, 2024
6 checks passed
@1riatsila1 1riatsila1 deleted the ay/feat/client-networks branch September 12, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants