Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: root group data source #17

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Conversation

1riatsila1
Copy link
Contributor

@1riatsila1 1riatsila1 commented Sep 3, 2024

Description

Introduce root group data source and forbid importing root group as resource

Related Issue(s)

https://jira.arubanetworks.com/browse/UXI-8069

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 80.48780% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@b87fdf2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...g-api-provider/provider/data-sources/root_group.go 71.42% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage        ?   39.18%           
=======================================
  Files           ?       26           
  Lines           ?     2368           
  Branches        ?        0           
=======================================
  Hits            ?      928           
  Misses          ?     1324           
  Partials        ?      116           
Files with missing lines Coverage Δ
pkg/config-api-provider/provider/provider.go 100.00% <100.00%> (ø)
...kg/config-api-provider/provider/resources/group.go 56.86% <100.00%> (ø)
pkg/config-api-provider/test/utils.go 100.00% <100.00%> (ø)
...g-api-provider/provider/data-sources/root_group.go 71.42% <71.42%> (ø)

@1riatsila1 1riatsila1 force-pushed the ay/feat/root-node-data-source branch from a892576 to ee8945c Compare September 3, 2024 09:48
@1riatsila1 1riatsila1 merged commit da6d1a0 into main Sep 4, 2024
4 checks passed
@1riatsila1 1riatsila1 deleted the ay/feat/root-node-data-source branch September 4, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants