Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable more linting #144

Merged
merged 26 commits into from
Nov 28, 2024
Merged

fix: enable more linting #144

merged 26 commits into from
Nov 28, 2024

Conversation

SiasMey
Copy link
Contributor

@SiasMey SiasMey commented Nov 28, 2024

Description

  • fix: make the return lint happy
  • style: add empty line before return statements
  • chore: update linter list
  • fix: many http body left open memory leaks
  • fix: ignore some false positives from gosec
  • style: fix var names to follow style guidelines
  • fix: undo body.Close to find segfault
  • fix: close http response in client tests
  • fix: close a few more http clients
  • fix: and close some more
  • fix: close responses in live tests
  • fix: close responses in agent_group_assignment
  • fix: close responses in agent_group_assignments
  • fix: close response in service_group_assignments
  • fix: close responses in wireless_networks
  • fix: close response in service_test_groups
  • fix: close response in senso_group_assignments
  • fix: close most resonpses in resoruce_group
  • fix: close responses in network_group_assignments
  • fix: close the reamining provider http responses
  • fix: close results in live tests
  • *refactor: use error instead of string in response
  • fix: move defer to below error check
  • fix: move defer to after nil check for http response
  • chore: update lint config
  • chore: update linting config to enable ireturn

Related Issue(s)

Copy link
Contributor

@brandon-piner-aruba brandon-piner-aruba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. More go'ish

@SiasMey SiasMey merged commit 48d3407 into main Nov 28, 2024
2 checks passed
@SiasMey SiasMey deleted the sm/fix/uxi-9700-fix-more-lints branch November 28, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants