-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amplify backend actions for webviews #1731
Open
drkameleon
wants to merge
246
commits into
master
Choose a base branch
from
amplify-backend-actions-for-webviews
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drkameleon
added
enhancement
New feature or request
helpers
Issues related to Helper modules
ui
Issues related to the UI
new feature
New feature/addition
labels
Sep 24, 2024
…mplify-backend-actions-for-webviews
…mplify-backend-actions-for-webviews
…mplify-backend-actions-for-webviews
…mplify-backend-actions-for-webviews
…(embedded e.g. inside a dictionary/object)
github-actions
bot
added
vm
Issues related to the Virtual Machine implementation
error handling
Issues related to Error handling
labels
Dec 7, 2024
1 task
…mplify-backend-actions-for-webviews # Conflicts: # version/build
Rough draft of what I'm thinking about a possible Window implementation (that's gonna be internal!): (EDIT: This has been over-simplified in the end, but still following the idea of an "internal" custom type)
|
….com/arturo-lang/arturo into add-support-for-window-menus # Conflicts: # version/build
… `MenuItem` visible on the Nim side of things)
Add (better) support for window menus
…mplify-backend-actions-for-webviews # Conflicts: # version/build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3rd-party
Issues related to 3rd-party libraries and code
→ Collections
enhancement
New feature or request
helpers
Issues related to Helper modules
library
Issues related to the standard library
new feature
New feature/addition
ui
Issues related to the UI
→ Ui
vm
Issues related to the Virtual Machine implementation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, one of the different "access points" we have, so that our webviews communicate with the Arturo are backend actions. That is: named, function-like calls, available exclusively in this context (Webview <-> Arturo message passing) and are normally meant to offer system- or UI-specific functionality (e.g. "maximize the main window" ➡️
window.maximize
).Here, we'll attempt adding a few more of these actions and, thus, amplify a bit the spectrum of what can be done/accessed through the webview itself! 😉
Type of change