Update SearchBar to better match comps #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
mzikherman
reviewed
Feb 20, 2019
| <ContextProvider> | ||
| <SearchBar /> | ||
| </ContextProvider> | ||
| <> |
|
Deploy preview for artsy-reaction ready! Built with commit 84b9595 |
1 similar comment
pepopowitz
changed the title
damassi
reviewed
Feb 21, 2019
| @@ -42,12 +42,15 @@ export const PreviewGridItem: React.SFC<PreviewGridItemProps> = ({ | |||
| </Link> | |||
| <Link href={artwork.href} noUnderline> | |||
| <Box> | |||
| <Title size="2"> | |||
| <OverflowEllipsis size="2" italic> | |||
damassi
reviewed
Feb 21, 2019
| @@ -11,31 +12,34 @@ interface Props { | |||
|
|
|||
| export const SuggestionItem: SFC<Props> = ({ href, display, label, query }) => { | |||
| if (label === "FirstItem") { | |||
| // `color="black100"` is misleading. | |||
| // The actual color doesn't really matter - the child element controls the displayed color. | |||
| // We specify color only because it makes the text not underlined on hover. | |||
There was a problem hiding this comment.
This seems like it would make a good API improvement PR
There was a problem hiding this comment.
Yeah, definitely. We've been talking about this quirk in the <Link> component, and trying to figure out what to do with it. It meets the specs that were originally created in Zeplin, but it's confusing & misleading.
damassi
reviewed
Feb 21, 2019
|
This thing is a beauty, great work 👍 |
…s from dancing while loading
|
🚀 PR was released in v14.0.13 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a variety of styling changes, with the goal of matching the auto-suggest search bar to the Zeplin comps.
Included:
overflow: ellipsisfor artist names (search for Fiona Banner, and you'll see)Here's what it looks like now!