Removes serif from Text #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzucconi
commented
Jul 20, 2020
|
|
||
| @media (min-width: ${themeGet("breakpoints.0")}) { | ||
| ${variant({ variants: TEXT_VARIANTS.large })} | ||
| ${textMixin} |
There was a problem hiding this comment.
Just PR-creeped this bug fix in. Due to how styled-components emits the media query CSS, we need to double include the textMixin in both contexts so when you specify say a solid line-height for Text (which is what I need in the NavBar, for instance — a valid use-case, the media query doesn't override it.
|
LGTM 👍 #mergeongreen |
dzucconi
force-pushed
the
remove-serif-add-ellipsis
branch
from
39a507a to
510f1c0
Compare
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds the
overflowEllipsisoption, and updates the typography docs. I would have added a bit more to those but I can't get the docs to actually compile correctly.