Skip to content

Commit

Permalink
Merge pull request #14394 from artsy/DIA-789-move-non-critical-code-i…
Browse files Browse the repository at this point in the history
…n-boot

fix: removes focus-visible polyfill
  • Loading branch information
dzucconi authored Aug 26, 2024
2 parents 3eafcd7 + fb188f0 commit 0297ec2
Show file tree
Hide file tree
Showing 9 changed files with 22 additions and 43 deletions.
5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@
"@artsy/icons": "3.19.0",
"@artsy/img": "1.0.3",
"@artsy/multienv": "^1.2.0",
"@artsy/palette": "38.13.2",
"@artsy/palette-charts": "37.13.2",
"@artsy/palette": "38.13.4",
"@artsy/palette-charts": "37.13.4",
"@artsy/react-html-parser": "^3.0.2",
"@artsy/to-title-case": "^1.1.0",
"@artsy/xapp": "1.0.6",
Expand Down Expand Up @@ -131,7 +131,6 @@
"express-ipfilter": "0.2.1",
"express-request-id": "1.4.0",
"farce": "0.4.5",
"focus-visible": "5.1.0",
"formik": "^2.2.9",
"found": "^1.3.0",
"found-relay": "^1.0.2",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ const buttonMixin = css`
&:hover,
&:focus,
&.focus-visible {
&:focus-visible {
outline: none;
color: ${themeGet("colors.white100")};
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ const NextPrevious = styled(Clickable)`
&:hover,
&:focus,
&.focus-visible {
&:focus-visible {
outline: none;
color: ${themeGet("colors.black10")};
}
Expand Down
2 changes: 1 addition & 1 deletion src/Apps/Show/Components/ShowInstallShots.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ const NextPrevious = styled(Clickable).attrs({
&:hover,
&:focus,
&.focus-visible {
&:focus-visible {
outline: none;
color: ${themeGet("colors.black100")};
}
Expand Down
18 changes: 0 additions & 18 deletions src/Components/FocusVisible.tsx

This file was deleted.

2 changes: 1 addition & 1 deletion src/Components/NavBar/NavBarPrimaryLogo.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const HitArea = styled(RouterLink)`
box-sizing: content-box;
}
&.focus-visible {
&:focus-visible {
outline: none;
> svg {
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Search/Mobile/OverlayBase.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ const Close = styled(Clickable)`
color: ${themeGet("colors.black100")};
&:focus,
&.focus-visible {
&:focus-visible {
outline: none;
color: ${themeGet("colors.black60")};
}
Expand Down
2 changes: 0 additions & 2 deletions src/System/Boot.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { data as sd } from "sharify"
import { Provider as StateProvider } from "unstated"
import Events from "Utils/Events"
import { getENV } from "Utils/getENV"
import { FocusVisible } from "Components/FocusVisible"
import { MatchingMediaQueries, MediaContextProvider } from "Utils/Responsive"
import { SiftContainer } from "Utils/SiftContainer"
import { setupSentryClient } from "Server/setupSentryClient"
Expand Down Expand Up @@ -90,7 +89,6 @@ export const Boot = track(undefined, {
keys={PROGRESSIVE_ONBOARDING_KEYS}
>
<CookieConsentManager>
<FocusVisible />
<SiftContainer />

{children}
Expand Down
30 changes: 15 additions & 15 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,12 @@
dependencies:
dotenv "^10.0.0"

"@artsy/[email protected].2":
version "37.13.2"
resolved "https://registry.yarnpkg.com/@artsy/palette-charts/-/palette-charts-37.13.2.tgz#b1524b8c0f3a35f2fe75451cb9e64901a2d177d1"
integrity sha512-W3p13h0xKteLw0ODSd5H6U1aGp8O8Yp3C8NpvsOVuWssx73y0uJFfegL6VmQSk4v/5GPK4pwb9Sd6MTxLUXflg==
"@artsy/[email protected].4":
version "37.13.4"
resolved "https://registry.yarnpkg.com/@artsy/palette-charts/-/palette-charts-37.13.4.tgz#3b6faff7679d13d76750df744560fb0f4875bec8"
integrity sha512-jbjmX3RVqcqZoxn639dZ8WZsPb4+Ti0ylP7vlZ7Kl5Fb/kbhUSSfRQaHaPh1zl30hm4lakagDKVPWoF3zvvmhQ==
dependencies:
"@artsy/palette" "^38.13.2"
"@artsy/palette" "^38.13.4"
"@seznam/compose-react-refs" "^1.0.6"
"@styled-system/theme-get" "^5.1.2"
d3-interpolate "^1.3.2"
Expand All @@ -101,16 +101,16 @@
resolved "https://registry.yarnpkg.com/@artsy/palette-tokens/-/palette-tokens-6.0.3.tgz#48b5854039e7f494fdef75e2d84682447f447f2d"
integrity sha512-Iuq3hjvx6O2d1glmuoo1kFnMLOBJFW2OuQ4Q5fXS1Q/DMAvjwrBmmzZE6HVzwR5BwX5Xy6knRiD8FuPrldeo0Q==

"@artsy/[email protected].2", "@artsy/palette@^38.13.2":
version "38.13.2"
resolved "https://registry.yarnpkg.com/@artsy/palette/-/palette-38.13.2.tgz#c4ed80f769c1ac514b5632a512a89fbe685289ed"
integrity sha512-gFKFg2OgM+jglyEKp6kHkbGX2mWLzgzTdUt+jUlVGDT64tyywUPzxxrK5fsSlVEp8MXAV1y3ycKWV5HtlVDyBA==
"@artsy/[email protected].4", "@artsy/palette@^38.13.4":
version "38.13.4"
resolved "https://registry.yarnpkg.com/@artsy/palette/-/palette-38.13.4.tgz#5ac87fbf9c6311224882b889041838cabed00fb1"
integrity sha512-Iej4WnDIO02WpctWYLUCz2r00sCkHSEIrWIZlTEVabLnTMbvbvWHHsRMB9QX4AX7jKwnsm3SvICBmvCMzaRRwg==
dependencies:
"@artsy/icons" "^3.2.2"
"@artsy/palette-tokens" "^6.0.3"
"@seznam/compose-react-refs" "^1.0.6"
"@styled-system/theme-get" "^5.1.2"
lodash "^4.17.21"
es-toolkit "^1.16.0"
proportional-scale "^4.0.0"
react-focus-on "^3.7.0"
react-lazy-load-image-component "1.5.5"
Expand Down Expand Up @@ -10425,6 +10425,11 @@ es-to-primitive@^1.2.1:
is-date-object "^1.0.1"
is-symbol "^1.0.2"

es-toolkit@^1.16.0:
version "1.16.0"
resolved "https://registry.yarnpkg.com/es-toolkit/-/es-toolkit-1.16.0.tgz#add09e46d52ea75531a94280f261dfc57b131984"
integrity sha512-eNJh3zF1KmAHRYd1D8rFi1cMFMCjrC6tumBfwuuZdSur97mED/ifyeBoGzxS11L4owCMx3XSmWTo6oxJQkdGng==

es5-shim@^4.5.13:
version "4.5.15"
resolved "https://registry.yarnpkg.com/es5-shim/-/es5-shim-4.5.15.tgz#6a26869b261854a3b045273f5583c52d390217fe"
Expand Down Expand Up @@ -11541,11 +11546,6 @@ focus-lock@^0.11.6:
dependencies:
tslib "^2.0.3"

[email protected]:
version "5.1.0"
resolved "https://registry.yarnpkg.com/focus-visible/-/focus-visible-5.1.0.tgz#4b9d40143b865f53eafbd93ca66672b3bf9e7b6a"
integrity sha512-nPer0rjtzdZ7csVIu233P2cUm/ks/4aVSI+5KUkYrYpgA7ujgC3p6J7FtFU+AIMWwnwYQOB/yeiOITxFeYIXiw==

follow-redirects@^1.0.0, follow-redirects@^1.14.0:
version "1.15.6"
resolved "https://registry.yarnpkg.com/follow-redirects/-/follow-redirects-1.15.6.tgz#7f815c0cda4249c74ff09e95ef97c23b5fd0399b"
Expand Down

0 comments on commit 0297ec2

Please sign in to comment.