feat: send additional Sift events on Android #8991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@MounirDhahri mind pulling this down and confirming you're still seeing events correctly fired? Would be greatly appreciated 🙂 |
gkartalis
reviewed
Jul 14, 2023
MounirDhahri
requested changes
Jul 14, 2023
| SiftReactNative.setPageName(`screen_${initialRouteName}`) | ||
| SiftReactNative.upload() | ||
| } | ||
| }, []) |
There was a problem hiding this comment.
issue(blocker): I think you need to trigger this only after the navigation is ready, otherwise it will be empty initially in case the navigation is not yet ready.
There was a problem hiding this comment.
Actually, even better, you might want to move this to be within onReady prop in the NavigationContainer to avoid watching the onReady global state
There was a problem hiding this comment.
Good catch, thank you! Updated in 3d08ba5
MounirDhahri
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #8370.
Sift's React Native package doesn't correctly upload events without manual calls. This means we've had a few Sift events on Android (on app open + user login), but not as many as we'd like. The recommendation from the folks who worked on it is to add these calls on navigate.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.