Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add submit artwork addional documents screen #10493

Merged
merged 4 commits into from
Aug 1, 2024
Merged

feat: add submit artwork addional documents screen #10493

merged 4 commits into from
Aug 1, 2024

Conversation

MounirDhahri
Copy link
Member

@MounirDhahri MounirDhahri commented Jul 16, 2024 •
edited
Loading

This PR resolves ONYX-1122

Description

This PR adds Artwork Additional Documents screen to the submission flow

Test case HeaderVideo
User Can manage new/old uploaded documents
Screen.Recording.2024-07-31.at.12.41.06.mov
Validation
Screen.Recording.2024-07-31.at.12.43.20.mov

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • add artwork additional documents screen to SWA flow - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri self-assigned this Jul 16, 2024
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Jul 16, 2024 •
edited
Loading

This PR contains the following changes:

  • Cross-platform user-facing changes (add artwork additional documents screen to SWA flow - mounir)

Generated by 🚫 dangerJS against 8d02349

@MounirDhahri MounirDhahri force-pushed the feat/add-additional-documents branch from 6408931 to 8d3bf82 Compare July 24, 2024 09:18
@MounirDhahri MounirDhahri force-pushed the feat/add-additional-documents branch from 8d3bf82 to 6303e1d Compare July 31, 2024 13:32
@MounirDhahri MounirDhahri marked this pull request as ready for review July 31, 2024 13:35
@MounirDhahri MounirDhahri mentioned this pull request Jul 31, 2024
Closed
@MounirDhahri MounirDhahri force-pushed the feat/add-additional-documents branch from 6303e1d to 409e0b4 Compare July 31, 2024 13:40
olerichter00
olerichter00 previously approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@olerichter00 olerichter00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great PR! 🌟

I've just added a couple of questions and minor suggestions.

ios/Artsy/App_Resources/Info.plist Show resolved Hide resolved
src/app/Scenes/SellWithArtsy/ArtworkForm/Components/SubmitArtworkAdditionalDocuments.tsx Outdated Show resolved Hide resolved
src/app/Scenes/SellWithArtsy/ArtworkForm/Components/SubmitArtworkAdditionalDocuments.tsx Show resolved Hide resolved
src/app/Scenes/SellWithArtsy/ArtworkForm/Components/SubmitArtworkAdditionalDocuments.tsx Show resolved Hide resolved
src/app/Scenes/SellWithArtsy/ArtworkForm/Components/SubmitArtworkAdditionalDocuments.tsx Show resolved Hide resolved
...es/SellWithArtsy/ArtworkForm/Components/__tests__/SubmitArtworkAdditionalDocuments.tests.tsx Outdated Show resolved Hide resolved
...es/SellWithArtsy/ArtworkForm/Components/__tests__/SubmitArtworkAdditionalDocuments.tests.tsx Outdated
}))

// prettier-ignore
jest.mock("app/Scenes/SellWithArtsy/SubmitArtwork/UploadPhotos/utils/uploadDocumentToS3", () => ({ // pragma: allowlist secret
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what is this for?

// pragma: allowlist secret

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's for detect-secrets - it thinks this is a secret for some reason 😄

Copy link
Contributor

@olerichter00 olerichter00 Jul 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, but wouldn't detect-secret add this line to the .secrets.baseline file to know that this line can be ignored?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! anyway I think I find a way around this. By remove s3 from the name it doesn't think it's a secret anymore 😄

src/app/Scenes/SellWithArtsy/ArtworkForm/SubmitArtworkForm.tsx Outdated Show resolved Hide resolved
src/app/Scenes/SellWithArtsy/ArtworkForm/Utils/getInitialSubmissionValues.ts Outdated Show resolved Hide resolved
src/app/Scenes/SellWithArtsy/ArtworkForm/Utils/getInitialSubmissionValuesFromArtwork.ts Outdated Show resolved Hide resolved
@MounirDhahri MounirDhahri force-pushed the feat/add-additional-documents branch from 7cd75f0 to c924d01 Compare August 1, 2024 09:25
@MounirDhahri MounirDhahri added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Aug 1, 2024
@MounirDhahri MounirDhahri force-pushed the feat/add-additional-documents branch from c924d01 to 9ae6150 Compare August 1, 2024 09:32
dariakoko
dariakoko reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@dariakoko dariakoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Mounir!

ios/Artsy/App_Resources/Info.plist Show resolved Hide resolved
src/app/Scenes/MyCollection/Screens/Artwork/Components/MyCollectionArtworkSubmissionStatus.tsx Outdated Show resolved Hide resolved
src/app/Scenes/SellWithArtsy/ArtworkForm/SubmitArtworkForm.tsx Show resolved Hide resolved
src/app/Scenes/SellWithArtsy/ArtworkForm/Utils/getInitialSubmissionValues.ts Show resolved Hide resolved
src/app/Scenes/SellWithArtsy/SubmitArtwork/UploadPhotos/utils/addAssetToConsignment.ts Show resolved Hide resolved
src/app/Scenes/SellWithArtsy/SubmitArtwork/UploadPhotos/utils/uploadDocument.ts Show resolved Hide resolved
src/app/Scenes/SellWithArtsy/SubmitArtwork/UploadPhotos/utils/uploadFileToS3.ts Show resolved Hide resolved
src/app/Scenes/SellWithArtsy/ArtworkForm/Components/SubmitArtworkAdditionalDocuments.tsx Outdated Show resolved Hide resolved
@artsy-peril artsy-peril bot merged commit 47e8879 into main Aug 1, 2024
7 checks passed
@artsy-peril artsy-peril bot deleted the feat/add-additional-documents branch August 1, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakoko dariakoko dariakoko left review comments

@olerichter00 olerichter00 olerichter00 left review comments

Assignees

@MounirDhahri MounirDhahri

Labels
Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MounirDhahri @ArtsyOpenSource @olerichter00 @dariakoko