Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade and simplify browser testing setup #1549

Merged

Conversation

jonallured
Copy link
Member

This PR takes it's cues from the work @leamotta did over here on simplifying the browser testing setup on Volt: https://github.com/artsy/volt/pull/7459 and applies that pattern here in Convection. This PR is meant to unblock some issues over on #1548 so I can get Ruby upgraded to 3.1. 😅

/cc @artsy/amber-devs

@jonallured jonallured self-assigned this Dec 5, 2024
Copy link
Contributor

@jpotts244 jpotts244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏀 ⛹🏻‍♂️

@jonallured jonallured merged commit 13a574b into main Dec 5, 2024
3 checks passed
@jonallured jonallured deleted the jonallured/chore-upgrade-and-simplify-browser-testing-setup branch December 5, 2024 17:10
@artsy-peril artsy-peril bot mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants